[webkit-reviews] review requested: [Bug 237554] Unify 'transform-box' reference box computation : [Attachment 454560] Patch, v6

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 237554: Unify 'transform-box' reference box computation
https://bugs.webkit.org/show_bug.cgi?id=237554

Attachment 454560: Patch, v6

https://bugs.webkit.org/attachment.cgi?id=454560&action=review




--- Comment #9 from Nikolas Zimmermann <zimmermann at kde.org> ---
Created attachment 454560

  --> https://bugs.webkit.org/attachment.cgi?id=454560&action=review

Patch, v6

The latest iteration of the patch introduces FloatOrLayoutRect, which either
holds a FloatRect or LayoutRect (realized via variant<FloatRect, LayoutRect>)
-- this avoids all LayoutRect(fromFloatRect) hacks, present in previous
iterations of the patch and guarantees type-safety again. As benefit it allows
us to detect if we need to pixel snap or not (SVG stores FloatRects, no pixel
snapping should occour), simplifying quite a few parts in RenderLayer