[webkit-reviews] review requested: [Bug 237711] [LBSE] Activate SVG transform support through layers : [Attachment 454559] Patch, v6

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 13 16:43:47 PDT 2022


Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 237711: [LBSE] Activate SVG transform support through layers
https://bugs.webkit.org/show_bug.cgi?id=237711

Attachment 454559: Patch, v6

https://bugs.webkit.org/attachment.cgi?id=454559&action=review




--- Comment #5 from Nikolas Zimmermann <zimmermann at kde.org> ---
Created attachment 454559

  --> https://bugs.webkit.org/attachment.cgi?id=454559&action=review

Patch, v6

The latest iteration of the patch introduces FloatOrLayoutRect, which either
holds a FloatRect or LayoutRect (realized via variant<FloatRect, LayoutRect>)
-- this avoids all LayoutRect(fromFloatRect) hacks, present in previous
iterations of the patch and guarantees type-safety again. As benefit it allows
us to detect if we need to pixel snap or not (SVG stores FloatRects, no pixel
snapping should occour), simplifying quite a few parts in RenderLayer


More information about the webkit-reviews mailing list