[webkit-reviews] review granted: [Bug 237773] [JSC] Use addressTempRegister in loadValue(void *) on 32 bits : [Attachment 454471] Patch

[bugzilla-daemon at webkit.org]

Zan Dobersek (Reviews) <zdobersek at igalia.com> has granted Angelos
Oikonomopoulos <angelos at igalia.com>'s request for review:
Bug 237773: [JSC] Use addressTempRegister in loadValue(void *) on 32 bits
https://bugs.webkit.org/show_bug.cgi?id=237773

Attachment 454471: Patch

https://bugs.webkit.org/attachment.cgi?id=454471&action=review




--- Comment #2 from Zan Dobersek (Reviews) <zdobersek at igalia.com> ---
Comment on attachment 454471
  --> https://bugs.webkit.org/attachment.cgi?id=454471
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454471&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:76
> +    struct BoundsNonDoubleWordOffset {
> +	   static bool within(intptr_t value)
> +	   {
> +	       return (value >= -0xff) && (value <= 0xfff);
> +	   }
> +    };
> +    struct BoundsDoubleWordOffset {
> +	   static bool within(intptr_t value)
> +	   {
> +	       if (value < 0)
> +		   value = -value;
> +	       return !(value & ~0x3fc);
> +	   }
> +    };

We could argue about these types' names, but let's not.