[webkit-reviews] review denied: [Bug 237778] [Flatpack SDK] Api tests scripts have conflicting parameters with the flatpak scripts : [Attachment 454475] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Mar 12 03:35:37 PST 2022
Philippe Normand <pnormand at igalia.com> has denied review:
Bug 237778: [Flatpack SDK] Api tests scripts have conflicting parameters with
the flatpak scripts
https://bugs.webkit.org/show_bug.cgi?id=237778
Attachment 454475: Patch
https://bugs.webkit.org/attachment.cgi?id=454475&action=review
--- Comment #3 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 454475
--> https://bugs.webkit.org/attachment.cgi?id=454475
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=454475&action=review
>> Tools/glib/api_test_runner.py:403
>> + for arg in sys.argv:
>
> Shouldn't this be `argv` instead of `sys.argv`? (Happens to work in both
scripts because we are already passing `sys.argv` as `argv`)
Right, good point Lauro!
More information about the webkit-reviews
mailing list