[webkit-reviews] review granted: [Bug 237784] Finish implementing modify-headers actions for WKContentRuleList SPI : [Attachment 454513] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 11 15:14:56 PST 2022
Timothy Hatcher <timothy at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 237784: Finish implementing modify-headers actions for WKContentRuleList
SPI
https://bugs.webkit.org/show_bug.cgi?id=237784
Attachment 454513: Patch
https://bugs.webkit.org/attachment.cgi?id=454513&action=review
--- Comment #4 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 454513
--> https://bugs.webkit.org/attachment.cgi?id=454513
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=454513&action=review
> Source/WebCore/contentextensions/ContentExtensionActions.cpp:452
> + return JSObjectGetPropertyForKey(context, toObject(value),
JSValueMakeNumber(context, index), nullptr);
Can you use JSObjectGetPropertyAtIndex instead?
More information about the webkit-reviews
mailing list