[webkit-reviews] review granted: [Bug 237782] Delay responsiveness checks for the Network Process until it has finished initialization : [Attachment 454489] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 237782: Delay responsiveness checks for the Network Process until it has
finished initialization
https://bugs.webkit.org/show_bug.cgi?id=237782

Attachment 454489: Patch

https://bugs.webkit.org/attachment.cgi?id=454489&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 454489
  --> https://bugs.webkit.org/attachment.cgi?id=454489
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454489&action=review

r=me

> Source/WebKit/ChangeLog:10
> +	   Network process initialization can be slow but we have evidence that
it is true truly

true truly -> not truly?

> Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:371
> +	   m_delayedResponsivenessCheck = useLazyStop;

When m_didBeginResponsivenessChecks is true, the *first* useLazyStop value
wins, and all subsequent values are ignored so long as the timer is still
active.

When m_didBeginResponsivenessChecks is false, the *last* useLazyStop value
wins, and all previous values are overwritten.

Is this something we should care about? -- Maybe we don't care because
useLazyStop is just a performance optimization for the case where we do
schedule the timer?