[webkit-reviews] review granted: [Bug 237735] Adjust when _setPrivacyProxyFailClosedForUnreachableNonMainHosts is called : [Attachment 454406] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 237735: Adjust when _setPrivacyProxyFailClosedForUnreachableNonMainHosts is
called
https://bugs.webkit.org/show_bug.cgi?id=237735

Attachment 454406: Patch

https://bugs.webkit.org/attachment.cgi?id=454406&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 454406
  --> https://bugs.webkit.org/attachment.cgi?id=454406
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454406&action=review

r=me

> Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:346
> +	   || request.url().host() == parameters.topOrigin->host())

Is there a condition where (isMainFrameNavigation && parameters.topOrigin &&
request.url().host() != parameters.topOrigin->host())? If not, maybe we don't
need to check isMainFrameNavigation.