[webkit-reviews] review granted: [Bug 237696] [iOS] Fix ovserscroll-behavior for main document : [Attachment 454437] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Nikos Mouchtaris
<nmouchtaris at apple.com>'s request for review:
Bug 237696: [iOS] Fix ovserscroll-behavior for main document
https://bugs.webkit.org/show_bug.cgi?id=237696

Attachment 454437: Patch

https://bugs.webkit.org/attachment.cgi?id=454437&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 454437
  --> https://bugs.webkit.org/attachment.cgi?id=454437
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454437&action=review

> Source/WebKit/ChangeLog:10
> +	   UIScrollView should rubber band or not. Need to investigate adding a
test for this,
> +	   as this doesn't require the new UIKit SPI.

The comment about testing is no longer relevant.

>
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateI
OS.mm:232
> +#if HAVE(UIKIT_OVERSCROLL_BEHAVIOR_SUPPORT)
> +    scrollView._allowsParentToBeginHorizontally =
horizontalOverscrollBehavior == OverscrollBehavior::Auto;
> +    scrollView._allowsParentToBeginVertically = verticalOverscrollBehavior
== OverscrollBehavior::Auto;
> +#endif

I don't think we want to set this on the root scroll view. That would allow web
content to prevent scroll gestures in the web view from propagating to some
ancestor scroller.