[webkit-reviews] review granted: [Bug 237744] Allow table of contents on posts in special cases : [Attachment 454423] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 10 16:42:46 PST 2022


Devin Rousso <drousso at apple.com> has granted Jon Davis <jond at apple.com>'s
request for review:
Bug 237744: Allow table of contents on posts in special cases
https://bugs.webkit.org/show_bug.cgi?id=237744

Attachment 454423: Patch

https://bugs.webkit.org/attachment.cgi?id=454423&action=review




--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 454423
  --> https://bugs.webkit.org/attachment.cgi?id=454423
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454423&action=review

r=me

> Websites/webkit.org/wp-content/plugins/table-of-contents.php:24
> +    public static function tocEnabled ($post_type) {

Style: I think we'd prefer something like `shouldEnableTableOfContents`, as
future developers might not know what "toc" is ��  Unless `'build-toc'` is some
WordPress concept?


More information about the webkit-reviews mailing list