[webkit-reviews] review granted: [Bug 237717] [macOS] Image decoders should be restricted for Mail : [Attachment 454398] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted  review:
Bug 237717: [macOS] Image decoders should be restricted for Mail
https://bugs.webkit.org/show_bug.cgi?id=237717

Attachment 454398: Patch

https://bugs.webkit.org/attachment.cgi?id=454398&action=review




--- Comment #5 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 454398
  --> https://bugs.webkit.org/attachment.cgi?id=454398
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454398&action=review

r=me

> Source/WebCore/platform/graphics/cg/ImageDecoderCG.h:78
> +    static bool m_enableRestrictedDecoding;

For static variables, we use the "s_" prefix. "m_" for "member", "s_" for
"static".

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:450
> +	   if (auto trustdExtensionHandle =
SandboxExtension::createHandleForMachLookup("com.apple.trustd.agent"_s,
std::nullopt))
> +	       parameters.trustdExtensionHandle =
WTFMove(*trustdExtensionHandle);

In a follow-up, it would be nice to disconnect Mail from trustd.