[webkit-reviews] review granted: [Bug 237567] [WebAuthn] Support authenticatorSelection.residentKey ResidentKeyRequirement : [Attachment 454382] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 237567: [WebAuthn] Support authenticatorSelection.residentKey
ResidentKeyRequirement
https://bugs.webkit.org/show_bug.cgi?id=237567

Attachment 454382: Patch

https://bugs.webkit.org/attachment.cgi?id=454382&action=review




--- Comment #17 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 454382
  --> https://bugs.webkit.org/attachment.cgi?id=454382
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454382&action=review

My comments seem to have been addressed and I couldn't find any obvious issue.
Carrying over Brent's r+.

> Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorSelectionCriteria.h:45
> + at property (nonatomic) _WKResidentKeyRequirement residentKey;

Seems this is missing the availability macro.