[webkit-reviews] review granted: [Bug 237316] Do capture video frame downsampling in GPUProcess : [Attachment 454338] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 237316: Do capture video frame downsampling in GPUProcess
https://bugs.webkit.org/show_bug.cgi?id=237316

Attachment 454338: Patch

https://bugs.webkit.org/attachment.cgi?id=454338&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 454338
  --> https://bugs.webkit.org/attachment.cgi?id=454338
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454338&action=review

> Source/WebKit/ChangeLog:11
> +	   Since display tracks are already cloned remotely, we can merge
RemoteRealtimeDisplaySource and RemoteRealtimeVideoSource.

This is great!

> Source/WebCore/platform/mediastream/RealtimeMediaSource.h:265
>      virtual void startProducingData() { }
>      virtual void stopProducingData() { }
> +    virtual void endProducingData() { stop(); }

I think it will be easy for someone that doesn't already know how these classes
work to be confused about the difference between stopProducingData and
endProducingData.

Conceptually these methods start, pause, and stop  (or cancel?) capture, so
maybe they could be `startProducingData`, `pauseProducingData`, and
`stopProducingData`. Or maybe we should change all three:
`startDataProduction`, `pauseDataProduction`, and `endDataProduction`?

Renaming will touch a lot of files so it could be done in another patch

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:-4186
> -		418FCBE3271049DB00F96ECA /* RemoteRealtimeDisplaySource.cpp */
= {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path =
RemoteRealtimeDisplaySource.cpp; sourceTree = "<group>"; };
> -		418FCBE4271049DC00F96ECA /* RemoteRealtimeDisplaySource.h */ =
{isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path =
RemoteRealtimeDisplaySource.h; sourceTree = "<group>"; };

Can these files be deleted now?