[webkit-reviews] review granted: [Bug 237029] [WASM-GC] WIP: introduce structs : [Attachment 452850] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Dmitry
<dbezhetskov at igalia.com>'s request for review:
Bug 237029: [WASM-GC] WIP: introduce structs
https://bugs.webkit.org/show_bug.cgi?id=237029

Attachment 452850: Patch

https://bugs.webkit.org/attachment.cgi?id=452850&action=review




--- Comment #6 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 452850
  --> https://bugs.webkit.org/attachment.cgi?id=452850
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452850&action=review

r=me, should we rename the Signature class to something else. I worry that
we’re somewhat misusing that term from classical its classical meaning.

> Source/JavaScriptCore/wasm/WasmLimits.h:47
> +constexpr size_t maxStructFieldCount = 1000000;

That’s a huge number, can we handle things that large? Is that the spec limit?

> Source/JavaScriptCore/wasm/WasmSectionParser.cpp:61
> +		   return fail(i, "th struct types are not enabled");

Nit: Maybe “th type failed to parse…”, or does ‘fail’ say what section we are
in?