[webkit-reviews] review granted: [Bug 237657] [CSS Container Queries] Implement new container selection algorithm : [Attachment 454243] Patch

[bugzilla-daemon at webkit.org]

Antoine Quint <graouts at webkit.org> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 237657: [CSS Container Queries] Implement new container selection algorithm
https://bugs.webkit.org/show_bug.cgi?id=237657

Attachment 454243: Patch

https://bugs.webkit.org/attachment.cgi?id=454243&action=review




--- Comment #2 from Antoine Quint <graouts at webkit.org> ---
Comment on attachment 454243
  --> https://bugs.webkit.org/attachment.cgi?id=454243
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454243&action=review

> Source/WebCore/css/ContainerQueryParser.cpp:41
> +    auto consumeName = [&]() -> AtomString {

I never know just by glancing at the code, but have you tried leaving out the
explicit return type?

> Source/WebCore/css/ContainerQueryParser.cpp:50
> +    auto name = consumeName();

My personal preference is to call the lambda directly and not assign it an
intermediate value.