[webkit-reviews] review granted: [Bug 237665] [web-animations] font-variant-east-asian should support discrete animation : [Attachment 454257] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 237665: [web-animations] font-variant-east-asian should support discrete
animation
https://bugs.webkit.org/show_bug.cgi?id=237665

Attachment 454257: Patch

https://bugs.webkit.org/attachment.cgi?id=454257&action=review




--- Comment #6 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 454257
  --> https://bugs.webkit.org/attachment.cgi?id=454257
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454257&action=review

>> Source/WebCore/animation/CSSPropertyAnimation.cpp:2547
>> +	    destination.setFontDescription(WTFMove(description));
> 
> I'm confused.
https://drafts.csswg.org/css-fonts/#font-variant-east-asian-prop says Animation
type: discrete. Why do we need a blend function here but not in
https://bugs.webkit.org/show_bug.cgi?id=237662?

Oh, I see, it's because animations work at the RenderStyle layer, not the CSS
layer, and in RenderStyle (FontDescription, actually) we have 3 separate pieces
of state for this, so you can't use the built-in discrete infrastructure
because it doesn't know that the 3 values need to be set together.