[webkit-reviews] review granted: [Bug 237661] [web-animations] font-variant-alternates should support discrete animation : [Attachment 454251] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 9 16:51:39 PST 2022
Myles C. Maxfield <mmaxfield at apple.com> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 237661: [web-animations] font-variant-alternates should support discrete
animation
https://bugs.webkit.org/show_bug.cgi?id=237661
Attachment 454251: Patch
https://bugs.webkit.org/attachment.cgi?id=454251&action=review
--- Comment #3 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 454251
--> https://bugs.webkit.org/attachment.cgi?id=454251
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=454251&action=review
>> Source/WebCore/rendering/style/RenderStyle.h:376
>> + FontVariantAlternates fontVariantAlternates() const { return
fontDescription().variantAlternates(); }
>
> Do we need to fix RenderStyle::diff() for this?
No. It's handled by FontDescription::operator==().
More information about the webkit-reviews
mailing list