[webkit-reviews] review granted: [Bug 237650] [web-animations] font-synthesis should support discrete animation : [Attachment 454271] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 237650: [web-animations] font-synthesis should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237650

Attachment 454271: Patch

https://bugs.webkit.org/attachment.cgi?id=454271&action=review




--- Comment #4 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 454271
  --> https://bugs.webkit.org/attachment.cgi?id=454271
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454271&action=review

>> Source/WebCore/rendering/style/RenderStyle.h:376
>> +	FontSynthesis fontSynthesis() const { return
fontDescription().fontSynthesis(); }
> 
> Do we need to fix RenderStyle::diff() for this too?

No. This is handled by FontDescription::operator==().