[webkit-reviews] review requested: [Bug 226662] [GTK] Replace gtk-doc with gi-docgen : [Attachment 454294] The “getting there” patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has asked  for review:
Bug 226662: [GTK] Replace gtk-doc with gi-docgen
https://bugs.webkit.org/show_bug.cgi?id=226662

Attachment 454294: The “getting there” patch

https://bugs.webkit.org/attachment.cgi?id=454294&action=review




--- Comment #16 from Adrian Perez <aperez at igalia.com> ---
Created attachment 454294

  --> https://bugs.webkit.org/attachment.cgi?id=454294&action=review

The “getting there” patch



- Building the GTK port correctly generates GI+docs.
- Untested first attempt at generating GI+docs for WPE (only the JSC part for
now).
- Missing check mode when doing developer build with documentation disabled.
- Missing install targets.

In order to test before tackling bug #237681 one can do a build without using
the
Flatpak SDK, or entering the SDK shell and installing it with  a virtualenv
under
the gi-docgen/ subdirectory as mentioned in an earlier comment.