[webkit-reviews] review denied: [Bug 236728] Debug build failure after r246172: ASSERT_UNDER_CONSTEXPR_CONTEXT should work in constexpr contexts : [Attachment 454252] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 9 11:56:04 PST 2022


Yusuke Suzuki <ysuzuki at apple.com> has denied  review:
Bug 236728: Debug build failure after r246172: ASSERT_UNDER_CONSTEXPR_CONTEXT
should work in constexpr contexts
https://bugs.webkit.org/show_bug.cgi?id=236728

Attachment 454252: Patch

https://bugs.webkit.org/attachment.cgi?id=454252&action=review




--- Comment #31 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 454252
  --> https://bugs.webkit.org/attachment.cgi?id=454252
Patch

Please continue using switch (without default). This is useful to find which
code needs to be modified when a new compilation-mode is added. So, if it is
related to GCC's warning, please suppress warning.


More information about the webkit-reviews mailing list