[webkit-reviews] review requested: [Bug 237648] [web-animations] fill-rule should support discrete animation : [Attachment 454224] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 9 11:35:03 PST 2022


Simon Fraser (smfr) <simon.fraser at apple.com> has asked	for review:
Bug 237648: [web-animations] fill-rule should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237648

Attachment 454224: Patch

https://bugs.webkit.org/attachment.cgi?id=454224&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 454224
  --> https://bugs.webkit.org/attachment.cgi?id=454224
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454224&action=review

> Source/WebCore/rendering/style/RenderStyle.h:1429
> +    WindRule fillRule() const { return svgStyle().fillRule(); }
> +    void setFillRule(WindRule fillRule) {
accessSVGStyle().setFillRule(fillRule); }

Does RenderStyle::diff() need to check this?


More information about the webkit-reviews mailing list