[webkit-reviews] review granted: [Bug 237668] [CMake] Associate platform specific configuration with WinCairo : [Attachment 454266] Patch

[bugzilla-daemon at webkit.org]

Basuke Suzuki <Basuke.Suzuki at sony.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 237668: [CMake] Associate platform specific configuration with WinCairo
https://bugs.webkit.org/show_bug.cgi?id=237668

Attachment 454266: Patch

https://bugs.webkit.org/attachment.cgi?id=454266&action=review




--- Comment #4 from Basuke Suzuki <Basuke.Suzuki at sony.com> ---
Comment on attachment 454266
  --> https://bugs.webkit.org/attachment.cgi?id=454266
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454266&action=review

>>> Source/WebKit/PlatformWin.cmake:-170
>>> -
>> 
>> Is it okay to remove these definitions?
> 
> Yea they're in the cmakeconfig.h and using `add_definitions` is frowned upon
for modern CMake code anyways.

Great.