[webkit-reviews] review denied: [Bug 237317] PerformanceNavigationTiming Response Start unavailable when using Service Worker Cache : [Attachment 454185] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 237317: PerformanceNavigationTiming Response Start unavailable when using
Service Worker Cache
https://bugs.webkit.org/show_bug.cgi?id=237317

Attachment 454185: Patch

https://bugs.webkit.org/attachment.cgi?id=454185&action=review




--- Comment #10 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 454185
  --> https://bugs.webkit.org/attachment.cgi?id=454185
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454185&action=review

I was hoping there was a web platform test for this already and it would start
passing.  Looks like we'll need to write one.

>> Source/WebCore/Modules/cache/DOMCache.cpp:89
>> +	resourceResponse.setDeprecatedNetworkLoadMetrics(WTFMove(metrics));
> 
> NetworkResourceLoader does not fill the network load metrics in the same way
in case of a matching cache entry.
> Should we be consistent?
> Also, is this consistent with what other browsers are doing?

This is consistent with what other browsers are doing, but we still need to
look into what happens with the disk cache and with the other metrics