[webkit-reviews] review granted: [Bug 237651] [web-animations] increase the max number of animatable properties : [Attachment 454230] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 9 05:29:57 PST 2022


Antti Koivisto <koivisto at iki.fi> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 237651: [web-animations] increase the max number of animatable properties
https://bugs.webkit.org/show_bug.cgi?id=237651

Attachment 454230: Patch

https://bugs.webkit.org/attachment.cgi?id=454230&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 454230
  --> https://bugs.webkit.org/attachment.cgi?id=454230
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454230&action=review

> Source/WebCore/animation/CSSPropertyAnimation.cpp:2896
> +    COMPILE_ASSERT(animatableLonghandPropertiesCount +
animatableShorthandPropertiesCount < USHRT_MAX,
numberOfAnimatablePropertiesMustBeLessThanUShrtMax);

more modern C++ would say std::numeric_limits<unsigned short>::max()


More information about the webkit-reviews mailing list