[webkit-reviews] review requested: [Bug 237112] [XCBuild] libwebrtc's headers are copied via rsync and do not emit task outputs : [Attachment 454171] Patch for relanding

[bugzilla-daemon at webkit.org]

Elliott Williams <emw at apple.com> has asked  for review:
Bug 237112: [XCBuild] libwebrtc's headers are copied via rsync and do not emit
task outputs
https://bugs.webkit.org/show_bug.cgi?id=237112

Attachment 454171: Patch for relanding

https://bugs.webkit.org/attachment.cgi?id=454171&action=review




--- Comment #13 from Elliott Williams <emw at apple.com> ---
Created attachment 454171

  --> https://bugs.webkit.org/attachment.cgi?id=454171&action=review

Patch for relanding

libabsl.xcconfig was not setting PUBLIC_HEADERS_FOLDER_PATH, due to a bad
copy-paste. This was causing build failures. I'm guessing I forgot to clean
when I tested the patch yesterday, so I didn't notice the headers in the wrong
location.

This patch runs s/PREFIX/PATH/g on libabsl.xcconfig, which fixes the issue:

	diff --git
a/Source/ThirdParty/libwebrtc/Configurations/libabsl.xcconfig
b/Source/ThirdParty/libwebrtc/Configurations/libabsl.xcconfig
	index 896b098ddc7d..57d61fe0fd01 100644
	--- a/Source/ThirdParty/libwebrtc/Configurations/libabsl.xcconfig
	+++ b/Source/ThirdParty/libwebrtc/Configurations/libabsl.xcconfig
	@@ -24,6 +24,6 @@
	 PRODUCT_NAME = absl;

	 APPLY_RULES_IN_COPY_HEADERS = $(WK_USE_NEW_BUILD_SYSTEM);
	-PUBLIC_HEADERS_FOLDER_PREFIX =
$(PUBLIC_HEADERS_FOLDER_PREFIX_$(WK_WHICH_BUILD_SYSTEM));
	-PUBLIC_HEADERS_FOLDER_PREFIX_not_legacy = /usr/local/include/absl;
	-PUBLIC_HEADERS_FOLDER_PREFIX_legacy =
/usr/local/include/absl_flattened;
	+PUBLIC_HEADERS_FOLDER_PATH =
$(PUBLIC_HEADERS_FOLDER_PATH_$(WK_WHICH_BUILD_SYSTEM));
	+PUBLIC_HEADERS_FOLDER_PATH_not_legacy = /usr/local/include/absl;
	+PUBLIC_HEADERS_FOLDER_PATH_legacy = /usr/local/include/absl_flattened;