[webkit-reviews] review granted: [Bug 237627] Combine Lookup and Define. : [Attachment 454169] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 237627: Combine Lookup and Define.
https://bugs.webkit.org/show_bug.cgi?id=237627

Attachment 454169: Patch

https://bugs.webkit.org/attachment.cgi?id=454169&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 454169
  --> https://bugs.webkit.org/attachment.cgi?id=454169
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454169&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:-4243
> -    MCProfileConnection *connection = [PAL::getMCProfileConnectionClass()
sharedConnection];
> -    if ([connection
effectiveBoolValueForSetting:PAL::get_ManagedConfiguration_MCFeatureDefinitionL
ookupAllowed()] == MCRestrictedBoolExplicitNo)

Funny that I don't see equivalent code in _lookupForWebView. Still, since this
was dead code until a recent change, we should be OK. Maybe Lookup does it
internally?