[webkit-reviews] review granted: [Bug 236487] WebGL context should use discrete gpu if the context is created when the window is on external monitor, ANGLE Metal backend : [Attachment 454109] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 236487: WebGL context should use discrete gpu if the context is created
when the window is on external monitor, ANGLE Metal backend
https://bugs.webkit.org/show_bug.cgi?id=236487

Attachment 454109: Patch

https://bugs.webkit.org/attachment.cgi?id=454109&action=review




--- Comment #5 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 454109
  --> https://bugs.webkit.org/attachment.cgi?id=454109
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454109&action=review

Looks great. A couple of small comments, but r+.

> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:161
> +	       // is anyway already powered on.

Perhaps mention here that this code relies on the assumption that
EGL_ANGLE_platform_angle_device_id uses the IOKit registry ID of the GPU on Mac
platforms?

> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:163
> +		  
displayAttributes.append(EGL_PLATFORM_ANGLE_DEVICE_ID_HIGH_ANGLE);

Would you like to at least ASSERT the availability of the
EGL_ANGLE_platform_angle_device_id EGL client extension somewhere?