[webkit-reviews] review denied: [Bug 237590] Allow to override CSS transform in RenderStyle::applyTransform() : [Attachment 454086] Patch, v1

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied  review:
Bug 237590: Allow to override CSS transform in RenderStyle::applyTransform()
https://bugs.webkit.org/show_bug.cgi?id=237590

Attachment 454086: Patch, v1

https://bugs.webkit.org/attachment.cgi?id=454086&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 454086
  --> https://bugs.webkit.org/attachment.cgi?id=454086
Patch, v1

View in context: https://bugs.webkit.org/attachment.cgi?id=454086&action=review

> Source/WebCore/rendering/style/RenderStyle.cpp:1474
> +    if (transformOperations.size()) {
> +	   for (auto& operation : transformOperations.operations())
> +	       operation->apply(transform, boundingBox.size());
> +    } else if (externalAffineTransformationSource) {
> +	   // SVG may provide additional non-CSS transformation operations.
> +	  
transform.multiplyAffineTransform(externalAffineTransformationSource());
> +    }

It's weird that this is either-or. From the function signature I would expect
that the result of externalAffineTransformationSource would get multiplied with
the style's transforms. Especially since this function DOES use the individual
transform properties.