[webkit-reviews] review granted: [Bug 236131] Allow to pass webrtc video frame buffers through RealtimeMediaSource based pipelines : [Attachment 453720] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 236131: Allow to pass webrtc video frame buffers through
RealtimeMediaSource based pipelines
https://bugs.webkit.org/show_bug.cgi?id=236131

Attachment 453720: Patch

https://bugs.webkit.org/attachment.cgi?id=453720&action=review




--- Comment #9 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 453720
  --> https://bugs.webkit.org/attachment.cgi?id=453720
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453720&action=review

> Source/WebCore/ChangeLog:14
> +	   In case we send VideoFrameLibWebRTC through
RealtimeOutgoingVideoSourceCocoa, directly send the video frame buffer.
> +	   When receiving libwebrtc video frame buffers in
RealtimeIncomingVideoSourceCocoa, make use of VideoFrameLibWebRTC to delay
conversion of the video frame buffer in a CVPixelBufferRef.
> +	   In most cases, the conversion is unneeded as the video frame buffer
will be used for rendering and will be copied to shared memory through
SharedVideoFrameWriter.
> +	   Fix bugs in handling of YUV conversion libwebrtc routines.
> +	   Minor refactoring to have a default asVideoFrameCV method
implementatin in VideoFrame.

Nit: these lines are really long