[webkit-reviews] review granted: [Bug 237030] [JSC] Make runner should only schedule tests on live remotes : [Attachment 452851] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Angelos Oikonomopoulos
<angelos at igalia.com>'s request for review:
Bug 237030: [JSC] Make runner should only schedule tests on live remotes
https://bugs.webkit.org/show_bug.cgi?id=237030

Attachment 452851: Patch

https://bugs.webkit.org/attachment.cgi?id=452851&action=review




--- Comment #3 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 452851
  --> https://bugs.webkit.org/attachment.cgi?id=452851
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452851&action=review

> Tools/Scripts/run-jsc-stress-tests:2584
> +	   "sysctl -n hw.activecpu 2>/dev/null || nproc --all 2>/dev/null"

I remember we chatted about using “getconf _NPROCESSORS_ONLN” here as one last
resort option, so you might want to add that before landing. Nevertheless,
given
that it's not currently needed for the runners where this has to work, feel
free
to land the patch as-is.