[webkit-reviews] review granted: [Bug 237537] File System Access: throw exception if file or directory cannot be accessed in file system : [Attachment 454041] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 8 01:03:07 PST 2022


youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 237537: File System Access: throw exception if file or directory cannot be
accessed in file system
https://bugs.webkit.org/show_bug.cgi?id=237537

Attachment 454041: Patch

https://bugs.webkit.org/attachment.cgi?id=454041&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 454041
  --> https://bugs.webkit.org/attachment.cgi?id=454041
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454041&action=review

> Source/WebKit/NetworkProcess/storage/FileSystemStorageHandle.cpp:60
> +	   return nullptr;

Should we add release logging if we are not able to create the file handle?


More information about the webkit-reviews mailing list