[webkit-reviews] review granted: [Bug 204744] Consider implementing Fetch Metadata. : [Attachment 454016] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Patrick Griffis
<pgriffis at igalia.com>'s request for review:
Bug 204744: Consider implementing Fetch Metadata.
https://bugs.webkit.org/show_bug.cgi?id=204744

Attachment 454016: Patch

https://bugs.webkit.org/attachment.cgi?id=454016&action=review




--- Comment #22 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 454016
  --> https://bugs.webkit.org/attachment.cgi?id=454016
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454016&action=review

> Source/WebCore/loader/CrossOriginAccessControl.cpp:224
> +    }

I do not think we need to add SecFetch here since these headers cannot be set
by the web application.
We can remove them unilaterally, which should further simplify\y the patch.

As said before, this change might cause removal of those headers in WK1 in case
of cross site redirection for CORS loads.
Can you validate that we have proper testing for this case?

> Source/WebCore/loader/FetchOptions.h:80
> +String convertEnumerationToString(FetchOptions::Mode);

Given we are only using them in one place for now, can we move these
declarations close to the call site?

> Source/WebCore/loader/cache/CachedResourceRequest.cpp:34
> +#include "Frame.h"

No longer needed?