[webkit-reviews] review granted: [Bug 237493] [iOS] Flash media controls when a fullscreen video resets its source : [Attachment 454022] Fix build failures

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 7 16:32:14 PST 2022


Jer Noble <jer.noble at apple.com> has granted Peng Liu <peng.liu6 at apple.com>'s
request for review:
Bug 237493: [iOS] Flash media controls when a fullscreen video resets its
source
https://bugs.webkit.org/show_bug.cgi?id=237493

Attachment 454022: Fix build failures

https://bugs.webkit.org/attachment.cgi?id=454022&action=review




--- Comment #5 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 454022
  --> https://bugs.webkit.org/attachment.cgi?id=454022
Fix build failures

View in context: https://bugs.webkit.org/attachment.cgi?id=454022&action=review

> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:100
> +#if !PLATFORM(WATCHOS)
> +- (void)flashPlaybackControlsWithDuration:(NSTimeInterval)duration;
> +#endif

Nit: let's move this into the AVKitSPI.h header.


More information about the webkit-reviews mailing list