[webkit-reviews] review granted: [Bug 207586] CSS style 'filter: drop-shadow...' does not render correctly without repaint. : [Attachment 454007] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 207586: CSS style 'filter: drop-shadow...' does not render correctly
without repaint.
https://bugs.webkit.org/show_bug.cgi?id=207586

Attachment 454007: Patch

https://bugs.webkit.org/attachment.cgi?id=454007&action=review




--- Comment #7 from zalan <zalan at apple.com> ---
Comment on attachment 454007
  --> https://bugs.webkit.org/attachment.cgi?id=454007
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454007&action=review

> Source/WebCore/rendering/RenderBox.cpp:4998
> +	   overflowMinX = std::min(overflowMinX, borderBox.x() - ((!isFlipped
|| isHorizontal) ? filterOutsets.left() : filterOutsets.right()));

"!isFlipped || isHorizontal" is a bit odd as horizontal could be flipped too
(horizontal-bt, though I don't think any language uses it)so this essentially
only flips for vertical writing mode.