[webkit-reviews] review denied: [Bug 215379] Implement HTTPServer for API tests in c++ : [Attachment 453917] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Takashi Komori
<takashi.komori at sony.com>'s request for review:
Bug 215379: Implement HTTPServer for API tests in c++
https://bugs.webkit.org/show_bug.cgi?id=215379

Attachment 453917: Patch

https://bugs.webkit.org/attachment.cgi?id=453917&action=review




--- Comment #31 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 453917
  --> https://bugs.webkit.org/attachment.cgi?id=453917
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453917&action=review

> Tools/TestWebKitAPI/ConnectionListener.h:99
> +class SecIdentityRef {

This isn't a great name.  It is a class that represents similar information to
what a SecIdentityRef points to on Cocoa platforms.  How about just "Identity"?

> Tools/TestWebKitAPI/ConnectionListener.h:114
> +class SecurityIdentityPEM {

Do you need this AND what is currently named SecIdentityRef?  They are kind of
two classes with the same function.

> Tools/TestWebKitAPI/ConnectionListener.h:132
> +    int m_bitLength { 0 };

nit: unsigned or size_t

> Tools/TestWebKitAPI/ConnectionListener.h:189
> +    bool complete { false };

I think it would be better to have parseHTTPRequest return a
std::optional<HTTPRequest> than to have this in the struct and require callers
to remember to check it.

> Tools/TestWebKitAPI/ConnectionPOSIX.cpp:130
> +    }

else?
We still need to call completionHandler.

> Tools/TestWebKitAPI/HTTPServer.cpp:148
> +    String pemEncodedPrivateKey(""

This should be moved instead of copied.  We don't want to introduce duplicate
copies of things like this.