[webkit-reviews] review requested: [Bug 197535] [GLib] Expose typed arrays in the public API : [Attachment 454040] WIP Patch v3

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has asked  for review:
Bug 197535: [GLib] Expose typed arrays in the public API
https://bugs.webkit.org/show_bug.cgi?id=197535

Attachment 454040: WIP Patch v3

https://bugs.webkit.org/attachment.cgi?id=454040&action=review




--- Comment #17 from Adrian Perez <aperez at igalia.com> ---
Created attachment 454040

  --> https://bugs.webkit.org/attachment.cgi?id=454040&action=review

WIP Patch v3


This version of the patch builds upon the one from bug #237088,
and I think it should address all the concerns that Carlos Garcia
had.

As for the allocation issue mentionex by Alex, it seems that creating
an ArrayBuffer first, and then using it as the memory area backing
a typed array works as expected even with non-gigacage allocations
(which IMO makes sense).

I will be uploading a version of the patch with added API tests, but
if anybody has feedback in the meantime, it would be appreciated.