[webkit-reviews] review granted: [Bug 237075] Add ability to convert FragmentedSharedBuffer to CMBlockBuffer : [Attachment 453093] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Jean-Yves Avenard [:jya]
<jean-yves.avenard at apple.com>'s request for review:
Bug 237075: Add ability to convert FragmentedSharedBuffer to CMBlockBuffer
https://bugs.webkit.org/show_bug.cgi?id=237075

Attachment 453093: Patch

https://bugs.webkit.org/attachment.cgi?id=453093&action=review




--- Comment #6 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 453093
  --> https://bugs.webkit.org/attachment.cgi?id=453093
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453093&action=review

> Source/WebCore/platform/SharedBuffer.cpp:162
> +    if (element->segment->size() - offsetInSegment >= length)

Is it possible for element->segment->size() to be < offsetInSegment? If not,
maybe an ASSERT() that states such?