[webkit-reviews] review granted: [Bug 235707] WebSocket.send() should synchronously update bufferedAmount : [Attachment 454023] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 235707: WebSocket.send() should synchronously update bufferedAmount
https://bugs.webkit.org/show_bug.cgi?id=235707

Attachment 454023: Patch

https://bugs.webkit.org/attachment.cgi?id=454023&action=review




--- Comment #11 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 454023
  --> https://bugs.webkit.org/attachment.cgi?id=454023
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454023&action=review

> Source/WebCore/Modules/websockets/WebSocket.cpp:352
> +    auto utf8 =
message.utf8(StrictConversionReplacingUnpairedSurrogatesWithFFFD);

Please see my comment on the other patch about doing this before the if check
above so we can use it inside the if check.