[webkit-reviews] review granted: [Bug 237549] Compilation error: WebContentProcess.xib: error: macOS xibs do not support target device type "ipad". : [Attachment 454017] Proposed fix v1

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Richard Houle
<rhoule at apple.com>'s request for review:
Bug 237549: Compilation error: WebContentProcess.xib: error: macOS xibs do not
support target device type "ipad".
https://bugs.webkit.org/show_bug.cgi?id=237549

Attachment 454017: Proposed fix v1

https://bugs.webkit.org/attachment.cgi?id=454017&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 454017
  --> https://bugs.webkit.org/attachment.cgi?id=454017
Proposed fix v1

View in context: https://bugs.webkit.org/attachment.cgi?id=454017&action=review

> Source/WebKit/Configurations/BaseXPCService.xcconfig:40
> +EXCLUDED_SOURCE_FILE_NAMES[sdk=macos*] =
$(EXCLUDED_SOURCE_FILE_NAMES_$(CONFIGURATION))
$(EXCLUDED_SOURCE_FILE_NAMES_$(WK_PLATFORM_NAME));

I guess configurations and platform names are disjoint sets, but merging
namespaces always gives me shivers.