[webkit-reviews] review granted: [Bug 237524] Add a preference to mute video capture in case audio capture gets interrupted : [Attachment 453987] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted  review:
Bug 237524: Add a preference to mute video capture in case audio capture gets
interrupted
https://bugs.webkit.org/show_bug.cgi?id=237524

Attachment 453987: Patch

https://bugs.webkit.org/attachment.cgi?id=453987&action=review




--- Comment #13 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 453987
  --> https://bugs.webkit.org/attachment.cgi?id=453987
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453987&action=review

r=me once the bots are happy

> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:521
> +	   if (!source.isEnded() && source.type() ==
RealtimeMediaSource::Type::Video)
> +	       source.setMuted(isMicrophoneInterrupted);

Shouldn't we also mute screen and window capture during and interruption?

> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:643
> +    if (wasInterrupted != m_isInterrupted && m_private->source().type() ==
RealtimeMediaSource::Type::Audio &&
document->settings().muteCameraOnMicrophoneInterruptionEnabled())
> +	   updateVideoCaptureAccordingMicrophoneInterruption(*document,
m_isInterrupted);

Won't this run multiple times if we have more than one audio track?