[webkit-reviews] review granted: [Bug 237516] PDF.js content script is adding custom cocoa style unconditionally : [Attachment 453953] Patch

[bugzilla-daemon at webkit.org]

Tim Nguyen (:ntim) <ntim at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 237516: PDF.js content script is adding custom cocoa style unconditionally
https://bugs.webkit.org/show_bug.cgi?id=237516

Attachment 453953: Patch

https://bugs.webkit.org/attachment.cgi?id=453953&action=review




--- Comment #2 from Tim Nguyen (:ntim) <ntim at apple.com> ---
Comment on attachment 453953
  --> https://bugs.webkit.org/attachment.cgi?id=453953
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453953&action=review

> Source/WebCore/html/PDFDocument.cpp:217
> +#if PLATFORM(COCOA)
> +    link->setAttribute(hrefAttr,
"webkit-pdfjs-viewer://pdfjs/extras/cocoa/style.css"_s);
> +#endif

Do #if preprocessing conditions not work in the JS file? If they do, I'd rather
see this logic in the JS file.