[webkit-reviews] review granted: [Bug 237527] [GTK][WPE] Add initial adwaita style for PDF.js : [Attachment 453972] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 237527: [GTK][WPE] Add initial adwaita style for PDF.js
https://bugs.webkit.org/show_bug.cgi?id=237527

Attachment 453972: Patch

https://bugs.webkit.org/attachment.cgi?id=453972&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 453972
  --> https://bugs.webkit.org/attachment.cgi?id=453972
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453972&action=review

> Source/WebCore/Modules/pdfjs-extras/adwaita/style.css:27
> +#openFile {
> +    display: none !important;
> +}

Is the file chooser not working?

> Source/WebCore/Modules/pdfjs-extras/adwaita/style.css:31
> +.dropdownToolbarButton > select {
> +    -webkit-appearance: none;
> +}

Hm, honestly I don't remember exactly what this hack was used for, other than
to hide something that was broken in Epiphany. Jan-Michael might remember for
sure.