[webkit-reviews] review granted: [Bug 237519] [GTK][WPE] Do not add new modules under ThirdParty to the tarball : [Attachment 453956] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 237519: [GTK][WPE] Do not add new modules under ThirdParty to the tarball
https://bugs.webkit.org/show_bug.cgi?id=237519

Attachment 453956: Patch

https://bugs.webkit.org/attachment.cgi?id=453956&action=review




--- Comment #4 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 453956
  --> https://bugs.webkit.org/attachment.cgi?id=453956
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453956&action=review

> Tools/gtk/manifest.txt.in:62
> +directory Source/ThirdParty/gtest

Another random note: I'm not sure this actually works from tarball builds. The
tests that use gtest probably require other stuff that's not in the tarballs.
Investigating that has been on my TODO for years. :P

I agree it's best not to change behavior in this patch, though.