[webkit-reviews] review requested: [Bug 237513] [GTK][WPE] Add initial support for PDF documents using PDF.js : [Attachment 453949] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 7 01:58:23 PST 2022
Carlos Garcia Campos <cgarcia at igalia.com> has asked for review:
Bug 237513: [GTK][WPE] Add initial support for PDF documents using PDF.js
https://bugs.webkit.org/show_bug.cgi?id=237513
Attachment 453949: Patch
https://bugs.webkit.org/attachment.cgi?id=453949&action=review
--- Comment #1 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Created attachment 453949
--> https://bugs.webkit.org/attachment.cgi?id=453949&action=review
Patch
This is an initial patch, loading PDF documents works, but there are a few
things to fix in follow up patches:
- Figure out a way to load platform styles. style-cocoa.css is currently added
unconditionally (we just get a 404 now and default style is used).
- I'm seeing a couple of cross-origin errors in the console, even though I
don't see anything broken.
- Add a style for GTK/WPE (adwaita), to remove UI elements we don't want, like
the open button, and customize the UI a bit too.
More information about the webkit-reviews
mailing list