[webkit-reviews] review granted: [Bug 237495] Replace IntRectExtent with RectEdges<int> : [Attachment 453895] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 237495: Replace IntRectExtent with RectEdges<int>
https://bugs.webkit.org/show_bug.cgi?id=237495

Attachment 453895: Patch

https://bugs.webkit.org/attachment.cgi?id=453895&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 453895
  --> https://bugs.webkit.org/attachment.cgi?id=453895
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453895&action=review

> Source/WebCore/platform/RectEdges.h:104
> +template<typename T>
> +inline RectEdges<T>& operator+=(RectEdges<T>& a, const RectEdges<T>& b)

I'd encourage you to write both += and + (you can usually have one call the
other).