[webkit-reviews] review granted: [Bug 237485] Modernize OriginLock : [Attachment 453871] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 237485: Modernize OriginLock
https://bugs.webkit.org/show_bug.cgi?id=237485

Attachment 453871: Patch

https://bugs.webkit.org/attachment.cgi?id=453871&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 453871
  --> https://bugs.webkit.org/attachment.cgi?id=453871
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453871&action=review

> Source/WebCore/Modules/webdatabase/OriginLock.h:-36
> -    WTF_MAKE_NONCOPYABLE(OriginLock); WTF_MAKE_FAST_ALLOCATED;

Why aren’t these helpful? I don’t understand this change.

> Source/WebCore/Modules/webdatabase/OriginLock.h:40
> +    static Ref<OriginLock> create(const String& originPath)
> +    {
> +	   return adoptRef(*new OriginLock(originPath));
> +    }

I don’t think we want to inline this. It would be better to have it in the .cpp
file, since we’d rather inline the constructor in the create function rather
than inlining the create function in the create call site.