[webkit-reviews] review granted: [Bug 237455] IDB serialization thread should pass isolated copy of IndexIDToIndexKeyMap to storage thread : [Attachment 453798] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 237455: IDB serialization thread should pass isolated copy of
IndexIDToIndexKeyMap to storage thread
https://bugs.webkit.org/show_bug.cgi?id=237455

Attachment 453798: Patch

https://bugs.webkit.org/attachment.cgi?id=453798&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 453798
  --> https://bugs.webkit.org/attachment.cgi?id=453798
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453798&action=review

r=me with improvement suggestion

> Source/WebCore/bindings/js/IDBBindingUtilities.cpp:506
> +	   indexKeys.add(entry.key, indexKey.isolatedCopy());

I recommend `WTFMove(indexKey).isolatedCopy()`. A lot of types (like String)
have special optimizations when isolatedCopy() is called on a r-value
expression.