[webkit-reviews] review granted: [Bug 237456] [Cocoa] Crash in MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL : [Attachment 453799] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 3 17:15:49 PST 2022


Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 237456: [Cocoa] Crash in
MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL
https://bugs.webkit.org/show_bug.cgi?id=237456

Attachment 453799: Patch

https://bugs.webkit.org/attachment.cgi?id=453799&action=review




--- Comment #4 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 453799
  --> https://bugs.webkit.org/attachment.cgi?id=453799
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453799&action=review

>
Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cp
p:1082
> +bool MediaPlayerPrivateAVFoundation::enableInheritURIQueryComponent() const

Nit: maybe shouldEnableInheritURIQueryComponent()?


More information about the webkit-reviews mailing list