[webkit-reviews] review requested: [Bug 237329] [XCBuild] Emit a discovered dependency file from offlineasm : [Attachment 453776] Integrate offlineasm using build rules and emit a depfile r6
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 3 12:11:10 PST 2022
Elliott Williams <emw at apple.com> has asked for review:
Bug 237329: [XCBuild] Emit a discovered dependency file from offlineasm
https://bugs.webkit.org/show_bug.cgi?id=237329
Attachment 453776: Integrate offlineasm using build rules and emit a depfile r6
https://bugs.webkit.org/attachment.cgi?id=453776&action=review
--- Comment #14 from Elliott Williams <emw at apple.com> ---
Created attachment 453776
--> https://bugs.webkit.org/attachment.cgi?id=453776&action=review
Integrate offlineasm using build rules and emit a depfile r6
Clarify boolean expression, fix multi-architecture builds, and keep generated
file outputs in their old locations
This fixes the bug Alexey noticed, where LLIntAssembly.h is no longer in the
build directory and its file reference in the Xcode project goes missing. It
also reduces the surface area of this change, since the pbxbuild and xcbuild
versions of this script always write to the same locations.
I mistakingly thought that offlineasm had to be run once per architecture -- in
reality, it wants to run once and generate assembly for all active platforms at
once. I have unchecked "Run once per architecture" in the build rules.
More information about the webkit-reviews
mailing list