[webkit-reviews] review granted: [Bug 237280] REGRESSION (r284472): [ Monterey ] http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html is failing : [Attachment 453748] Patch v1.3

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 237280: REGRESSION (r284472): [ Monterey ]
http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html is
failing
https://bugs.webkit.org/show_bug.cgi?id=237280

Attachment 453748: Patch v1.3

https://bugs.webkit.org/attachment.cgi?id=453748&action=review




--- Comment #7 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 453748
  --> https://bugs.webkit.org/attachment.cgi?id=453748
Patch v1.3

View in context: https://bugs.webkit.org/attachment.cgi?id=453748&action=review

r=me, nice fix! =D

> Source/WebCore/ChangeLog:20
> +	   correct this the `WebKit::WebSocketChannel` now provides a hook into
its helper `WebInspectorChannelInspector`

Did you mean `WebSocketChannelInspector`?

> Source/WebCore/Modules/websockets/WebSocket.cpp:614
> +	   if (auto* inspector = m_channel->channelInspector())

NIT: Should this also be wrapped in a `if
(UNLIKELY(InspectorInstrumentation::hasFrontends())) {`?