[webkit-reviews] review requested: [Bug 141586] Give WebKit-owned IOSurfaces names : [Attachment 453766] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 3 11:23:20 PST 2022


Ben Nham <nham at apple.com> has asked  for review:
Bug 141586: Give WebKit-owned IOSurfaces names
https://bugs.webkit.org/show_bug.cgi?id=141586

Attachment 453766: Patch

https://bugs.webkit.org/attachment.cgi?id=453766&action=review




--- Comment #7 from Ben Nham <nham at apple.com> ---
Comment on attachment 453766
  --> https://bugs.webkit.org/attachment.cgi?id=453766
Patch

I replaced logging the pointer to the backing store with logging the layer name
since that seemed more useful. I didn't implement naming canvas/webrtc/etc.
surfaces in this patch because that seems like it would require either
propagating the rendering purpose for the surface from WebChromeClient =>
RemoteRenderingBackendProxy => GPUProcess or it would require implementing
setName on RemoteImageBufferProxy. Not sure which way of doing it would be
preferred. Maybe we should just do that in another patch.


More information about the webkit-reviews mailing list